> On April 14, 2016, 1:27 p.m., Torsten Rahn wrote: > > Hi René - > > Review Requests have moved over to phabricator. > > Could you resubmit your patch at > > > > https://phabricator.kde.org/ > > > > It's nice to see work being done on the Mac front - would be great if we > > could offer a more recent Mac OS app bundle on the Marble website ... > > René J.V. Bertin wrote: > Dang, I was hoping to be able to put that off until KDevelop has a plugin > to upload patches directly O:-) > > As to your other remark: my primary interest is in providing Marble (and > its library) via a MacPorts port. But if I have time I might look into why > marble-qt doesn't build as an app bundle by default. > Apart from that, the current release version seems to build just fine one > way or another.
https://phabricator.kde.org/D1420 - René J.V. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127649/#review94604 ----------------------------------------------------------- On April 14, 2016, 12:47 p.m., René J.V. Bertin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127649/ > ----------------------------------------------------------- > > (Updated April 14, 2016, 12:47 p.m.) > > > Review request for KDE Software on Mac OS X and Marble. > > > Repository: marble > > > Description > ------- > > Disclaimer: the patch as presented is currently a hack that only shows what > is done, not how to do it properly. I'll clean it up if there is interest in > incorporating this as a selectable option. > > That being said, here's the point. > Marble currently aims to build 1 or 2 more or less standalone app bundles > when being built on Mac OS X. There is nothing wrong with that, but it > presents a problem for distribution systems like MacPorts or Fink or HomeBrew > that aim to share libraries among packages and to remain as close as possible > to the runtime context for which packages were designed (i.e. > XDG/Freedesktop). Evidently the goal is not to replace the OS X desktop with > a Plasma shell; rather, the idea is that the feature set will be most > complete and maintenance will be easiest when differences like where > resources are to be found are as small as possible. Think of it as running > KDE applications installed with their dependencies in some separate prefix, > under e.g. a Gnome, XFCE or even a "bare-bones X11" desktop environment. > > The patch achieves this by disabling all APPLE-specific things in the CMake > files except for the required frameworks (Apple's, not KF5), currently by > replacing APPLE with the unknown APPEL token. > The result is that there is still an app bundle that is created, for the > KF5-based marble (but not for marble-qt though that ought to be possible > too). A few additional lines create and install an application icon for > marble.app . Everything else is installed in its usual location under the > prefix. > > I would assume that this is more or less a prerequisite to build a package > like digiKam which can use libMarble ... which would be a lot less evident if > that library is hidden in a relocatable app bundle. > > If there is a chance that this patch is accepted I'd propose replacing the > APPEL hack with a variable like `option(BUILD_APPLE_APPBUNDLE,"build app > bundle(s)" YES)`. > > > Diffs > ----- > > CMakeLists.txt 28c9299 > src/CMakeLists.txt 063db88 > src/apps/marble-kde/CMakeLists.txt 2841052 > src/apps/marble-qt/CMakeLists.txt 5a242b6 > src/lib/astro/CMakeLists.txt c4dcd5b > src/lib/marble/CMakeLists.txt 42fe56f > src/plugins/runner/kml/CMakeLists.txt 573e149 > src/plugins/runner/osm/CMakeLists.txt 82091a5 > src/plugins/runner/shp/CMakeLists.txt cddaebf > tests/CMakeLists.txt d0db4d6 > > Diff: https://git.reviewboard.kde.org/r/127649/diff/ > > > Testing > ------- > > On OS X 10.9.5, with Qt 5.6 and FWs 5.20.0, installed under /opt/local > > > Thanks, > > René J.V. Bertin > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
