kossebau created this revision. kossebau added reviewers: Marble, rahn, nienhueser.
REVISION SUMMARY GeoPainter::drawEllipse() & GeoPainter::drawRect() both take the parameters width & height as qreal type, but if !isGeoProjected they do the actual rendering calls using int based coordinates & sizes. The old calculation would not compensate qreal->int rounding changes and often result in a wrong 1 pixel offset in direction of topleft corner. The respective GeoPainter::regionFromEllipse() and GeoPainter::regionFromRect() also are adapted, with the first also being fixed to take also strokeWidth into account for the topleft corner calculation, like done with the rect. TEST PLAN Extended geopainter example app renders rectangles and ellipses as expected. REPOSITORY rMARBLE Marble BRANCH fixEllipseRectanglePainting REVISION DETAIL https://phabricator.kde.org/D2141 AFFECTED FILES src/lib/marble/GeoPainter.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, #marble, rahn, nienhueser Cc: marble-devel
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
