sanjibanb added a comment.

  I was just wondering if there is a way to test these changes locally?

INLINE COMMENTS

> AndroidManifest.xml:22
>                          </intent-filter>
> -                        <meta-data android:name="android.app.lib_name" 
> android:value="-- %%INSERT_APP_LIB_NAME%% --"/>
> +                        <meta-data android:name="android.app.lib_name" 
> android:value="Marble"/>
>                          <meta-data 
> android:name="android.app.qt_sources_resource_id" 
> android:resource="@array/qt_sources"/>

Not too important, but can we change it from "Marble" to "MarbleMaps"? This 
would help distinguish it as the Android app and not the Desktop version.

Making similar changes in marble-maps/CMakeLists.txt as well would help retain 
this consistency.

REPOSITORY
  R34 Marble

REVISION DETAIL
  https://phabricator.kde.org/D13404

To: apol, #marble
Cc: sanjibanb, marble-devel, kde-edu, torhamzed, jalvarez, tjakobi, mnafees, 
shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser

Reply via email to