rahn added a comment.
apart from the Boolean issue this looks good to me and can be submitted. INLINE COMMENTS > GeoDataCoordinates.h:392 > */ > - QString toString( GeoDataCoordinates::Notation notation, int precision = > -1 ) const; > + QString toString( GeoDataCoordinates::Notation notation, int precision = > -1, bool orderLatLon = false ) const; > such booleans as parameters always look dull (https://ariya.io/2011/08/hall-of-api-shame-boolean-trap). What about using an enum instead ? REPOSITORY R34 Marble REVISION DETAIL https://phabricator.kde.org/D19329 To: mkoller, #marble_general, rahn, nienhueser Cc: marble-devel, kde-edu, torhamzed, jalvarez, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser
