Hi!
On 13.01.2011 01:11, Igor Babaev wrote:
At file:///home/igor/maria/maria-5.3-bugs/
------------------------------------------------------------
revno: 2876
revision-id: [email protected]
parent: [email protected]
committer: Igor Babaev<[email protected]>
branch nick: maria-5.3-bugs
timestamp: Wed 2011-01-12 15:10:59 -0800
message:
Fixed LP bug #698882.
Made sure that the optimal fields are used by TABLE_REF objects
when building index access keys to joined tables.
Fixed a bug in the template function that sorts the elements of
a list using the bubble sort algorithm. The bug caused poor
performance of the function. Also added an optimization that
skips comparison with the most heavy elements that has been
already properly placed in the list.
Made the comparison of the fields belonging to the same Item_equal
more granular: fields belonging to the same table are also ordered
according to some rules.
The patch as OK. But I'd prefer to have comment that the lists are
mostly short and because of this used bubble sort algorithm (or you
could use more detailed explanation from your letter to me).
Also in big 'if (!cmp)' used tabulation (it is visible if you check diff
where layout looks not correct, but it is correct in the result file),
if it is not difficult it would be better to remove them.
[skip]
_______________________________________________
Mailing list: https://launchpad.net/~maria-developers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~maria-developers
More help : https://help.launchpad.net/ListHelp
