On Sat, Apr 23, 2011 at 06:54:23PM -0700, Igor Babaev wrote:
> On 04/23/2011 05:26 PM, Sergey Petrunya wrote:
> > On Sun, Apr 24, 2011 at 03:08:12AM +0400, Sergey Petrunya wrote:
> >> Hello Igor,
> >>
> >> First, an overall comment: there are lots of typos/coding style violations
> >> in
> >> the patch. To reduce amount of effort spent on such things, I was just
> >> fixing
> >> them as I saw them and I'm attaching the patch with all the fixes (i.e.
> >> this
> >> patch should be applied on top of the patch that I was reviewing).
> >
> > Now really with attached file.
> >
> > BR
> > Sergey
>
> Sergey,
>
> In your diff I found only corrections for typos/phrasing. Not with all
> of them I agree. Nevertheless I'll fix them.
> I did not find any corrections of coding style violations. Do I miss
> anything?
I meant the changes like the following:
+++ 5.3-review-717577-comments/sql/item_cmpfunc.h 2011-04-24
00:09:32.000000000 +0400
@@ -1630,7 +1630,7 @@
over all items from the list of the Item_field/Item_direct_view_ref
classes.
*/
List<Item> equal_items;
- /*
+ /*
TRUE <-> one of the items is a const item.
Such item is always first in in the equal_items list
*/
@@ -1643,17 +1643,17 @@
/*
This initially is set to FALSE. It becomes TRUE when this item is evaluated
as being always false. If the flag is TRUE the contents of the list
- the equal_items should be ignored.
+ the equal_items should be ignored.
*/
BR
Sergey
--
Sergey Petrunia, Software Developer
Monty Program AB, http://askmonty.org
Blog: http://s.petrunia.net/blog
_______________________________________________
Mailing list: https://launchpad.net/~maria-developers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~maria-developers
More help : https://help.launchpad.net/ListHelp
