> -----Original Message----- > From: [email protected] [mailto:commits- > [email protected]] On Behalf Of Sergei Golubchik > Sent: Sonntag, 3. Februar 2013 18:17 > To: [email protected] > Cc: [email protected] > Subject: Re: [Commits] Rev 3657: MDEV-4127 : Export additional symbols > when building RPM > > Hi, Vladislav! > > May be you'd rather rename symbols with #define, just as redhat does?
Hi Sergei, It is possible. However, unless it is done conditionally (e.g #ifdef BUILD_MARIADB_AS_RPM), it is likely to break something (e.g odbc) on other (Debian-style) Linuxes. So I see 2 variants 1. Introduce BUILD_MARIADB_AS_RPM preprocessor constant, set to 1 if build with RPM. If BUILD_MARIADB_AS_RPM is set, do rename functions via #define , Redhat-style . 2. Export both original and renamed symbols, as in my patch. Both are ok to me. Which one would be better, what do you think? > On Feb 03, Vladislav Vaintroub wrote: > > At file:///H:/bzr/5.5/ > > > > ------------------------------------------------------------ > > revno: 3657 > > revision-id: [email protected] > > parent: [email protected] > > committer: Vladislav Vaintroub <[email protected]> > > branch nick: 5.5 > > timestamp: Sun 2013-02-03 17:45:16 +0100 > > message: > > MDEV-4127 : Export additional symbols when building RPM, > > to enable both recompiling mysqli or odbc from sources in addition > > to drop-in replacement functionality. > > > > The case in question is compiling mysqli from sources, that needs > > client_errors via ER() macro. > > > > Previously, we exported it as mysql_client_errors (compatibly to > > Fedora's style symbol renaming, see MDEV-3842). > > However, if MariaDB header files are used when compiling mysqli, > > client_errors needs to be exported with its original name. > > Regards, > Sergei > _______________________________________________ > commits mailing list > [email protected] > https://lists.askmonty.org/cgi-bin/mailman/listinfo/commits _______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp
