Hi, Sergey! On Sep 06, Sergey Vojtovich wrote: > 06.09.2013, в 15:29, Sergei Golubchik <[email protected]> написал(а): > > > > Perhaps it'd be better to rename used_for_duplicate_elimination to > > "force_dynamic_Aria_row_format" ? A prettier solution would be to > > introduce another flag: table->keep_row_order. > I submitted another patch with the "prettier" solution. Though I tend > to think that it'd be better not to fill TABLE object with things like > keep_row_order and used_for_duplicate_elimination - they can go as an > argument to create_internal_tmp_table(force_dynamic_aria_row_format).
Agree. But it may need more complex changes. Do as you like - either push your second patch, or fix the code to remove TABLE::used_for_duplicate_elimination and TABLE::keep_row_order. Regards, Sergei _______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp
