On Wed, Mar 11, 2015 at 10:10 AM, Sergei Golubchik <[email protected]> wrote: >> diff --git a/mysql-test/t/enforce_storage_engine.test >> b/mysql-test/t/enforce_storage_engine.test >> new file mode 100644 >> index 0000000..80839e2 >> --- /dev/null >> +++ b/mysql-test/t/enforce_storage_engine.test >> @@ -0,0 +1,64 @@ >> +-- source include/have_innodb.inc > > You can keep it this way, but I'd recommend to change to either > have_xtradb.inc or (better) not use innodb at all and test with myisam > and memory engines. > > with have_innodb.inc the test will be run twice - for innodb and for > xtradb, which is a waste of time, because it doesn't do anything > engine-specific here.
And with have_xtradb.inc it won't run for those who doesn't build XtraDB. So I'd suggest to not use that option unless you want to use some XtraDB-specific features. Pavel _______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp

