Hi Sergei, On Thu, Jun 18, 2015 at 08:44:46AM +0200, Sergei Golubchik wrote: > Hi, Sergey! > > On Jun 17, [email protected] wrote: > > revision-id: 2e08ec24623e0b3d3db02333e16658dcfaa0535c > > parent(s): b776f8d3a8afff55d5f8208da7bdfce9aa33eb39 > > committer: Sergey Vojtovich > > branch nick: mariadb > > timestamp: 2015-06-17 13:09:22 +0400 > > message: > > > > MDEV-7956 - handler::rebind_psi() takes 0.07% in OLTP RO > > > > Do not call handler::rebind_psi() and handler::unbind_psi() when performance > > schema is compiled out. > > > > Overhead change: > > handler::rebind_psi 0.04% -> out of radar > > handler::unbind_psi 0.03% -> out of radar > > open_table 0.21% -> 0.18% > > close_thread_table 0.05% -> 0.05% > > Really? I don't believe it. handler::rebind_psi() and > handler::unbind_psi() are empty methods, not doing anything. There's > only a cost a virtual function call. And you're saying that it took 15% > of the open_table() execution time? This can be noise. What matters here is that rebind_psi/unbind_psi went out of radar: this is sure sign of improvement. Can't remember why I included caller stats at all.
Regards, Sergey _______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp
