Hi Sergei,
On 08/08/2016 03:35 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Aug 08, Alexander Barkov wrote:
Hi Serg,
Please review a patch for MDEV-10500.
Thanks.
I think it's a caller's job to test for null_value.
Apparently, sometimes it tests for the return value being NULL, isn't
that wrong?
As discussed on IRC, there are many places assuming that
null_vallue==true is always in sync with val_decimal()/val_str()
returning NULL.
So it's safer to fix Item_sum_sum::val_decimal() rather than all callers.
Regards,
Sergei
Chief Architect MariaDB
and [email protected]
_______________________________________________
Mailing list: https://launchpad.net/~maria-developers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~maria-developers
More help : https://help.launchpad.net/ListHelp