On Mon, Nov 07, 2016 at 06:53:30AM +0100, Sergei Golubchik wrote: > On November 7, 2016 1:34:18 AM GMT+01:00, Sergey Petrunia > <ser...@mariadb.com> wrote: > >Hi Sergei, Elena > > > >I'm not sure who maintains mysql-test-run.pl but you two seem to have > >contributed to it in the past, this is why I'm addressing this to you. > > > >I'm going to get "MTR v2" to support --force-restart, just like MTR v1 > >did; > > > >http://lists.askmonty.org/pipermail/commits/2016-November/010062.html > >http://lists.askmonty.org/pipermail/commits/2016-November/010063.html > > > >Since I don't really understand this MTRv1 vs MTRv2 change (and why > >some things > >are in v1 but not in v2, etc), I wanted to check this change with you. > > No, please, don't add that. I've removed force-restart and all > other pseudo-arguments few years ago. There are many > ways to guarantee a restart without it - add some dummy > option to .opt file, add a .cnf file, add a .sh file, or - that's > what I did in old tests that needed force-restart (only about > 5-10% out of those, that used it!) - restart the server from > inside the test file.
Ok, I've reverted the above two patches, will restart the server from the .test file. BR Sergei -- Sergei Petrunia, Software Developer MariaDB Corporation | Skype: sergefp | Blog: http://s.petrunia.net/blog _______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp