Hi Monty! Thank you for starting this task. I appreciate it.
> Kentoku, do you have patches for the test files, or should I just take > them from the above spider branch or from somewhere else ? I just attached test files into MDEV-7698. Please use it. And please let me know if you get a error from test. Sometimes, test results are changed by patches. In this case I should check it. > I can't figure out,why we get the above warnings. > This is from a patch we discussed at booking.com one year ago. Any > explanation for the above warnings would be appreciated. > > You can branch 10.2-spider and check the current state. O.K. I'll check it. Thanks, Kentoku 2016-11-21 17:30 GMT+09:00 Michael Widenius <[email protected]>: > Hi! > > I have now started to work on the spider patches for MariaDB 10.2, MDEV-7698. > > I have moved all code from maria-10.1-spider to a new branch > maria-10.2-spider and added some more patches. > I have closed all related MDEV's in MDEV-7698 that is now included in > 10.2-spider. > > While doing this, I noticed that spider/handler test was not included > in the test suite. I added the missing suite.pm and suite.opt files > and got the tests to work. > > However, when I tried to run test to verify my changes, I noticed that > a lot of test in spider/handler where failing: > > mysql-test-run --suite=spider/handler > produces these failures: > > spider/handler.spider3_fixes spider/handler.direct_aggregate > spider/handler.direct_update spider/handler.spider_fixes > spider/handler.function spider/handler.ha spider/handler.vp_fixes > > All failures are because .test and .result file doesn't match. > > I checked the patch file: > http://spiderformysql.com/downloads/spider-3.2/patch_mariadb-10.1.8.tgz > but this doesn't include any updates to the handler test files: > grep mysql_test * returns nothing. > > However the .tar file: > http://spiderformysql.com/downloads/spider-3.2/mariadb-10.1.8-spider-3.2-vp-1.1.tgz > Contains a lot of updated .test and .result files. > > Kentoku, do you have patches for the test files, or should I just take > them from the above spider branch or from somewhere else ? > > Another question: > After applying the patches: > > 013_mariadb-10.0.15.vp_handler.diff > 034_mariadb-10.0.15.vp_handler2.diff > 005_mariadb-10.0.15.hs.diff > 041_mariadb-10.0.15.vp_handler2.diff > > I get the following change in spider/handler/basic_sql.result: > > --- a/storage/spider/mysql-test/spider/handler/r/basic_sql.result > +++ b/storage/spider/mysql-test/spider/handler/r/basic_sql.result > @@ -70,6 +70,12 @@ CREATE TABLE ta_l ( > PRIMARY KEY(a) > ) MASTER_1_ENGINE MASTER_1_CHARSET MASTER_1_COMMENT_2_1 > IGNORE SELECT a, b, c FROM tb_l > +Warnings: > +Warning 1062 Duplicate entry '1' for key 'PRIMARY' > +Warning 1062 Duplicate entry '2' for key 'PRIMARY' > +Warning 1062 Duplicate entry '3' for key 'PRIMARY' > +Warning 1062 Duplicate entry '4' for key 'PRIMARY' > +Warning 1062 Duplicate entry '5' for key 'PRIMARY' > > I can't figure out,why we get the above warnings. > This is from a patch we discussed at booking.com one year ago. Any > explanation for the above warnings would be appreciated. > > You can branch 10.2-spider and check the current state. > > Regards, > Monty > > _______________________________________________ > Mailing list: https://launchpad.net/~maria-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~maria-developers > More help : https://help.launchpad.net/ListHelp _______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp
