Hi Vlad, On 12/06/2017 04:29 PM, Vladislav Vaintroub wrote: > Hi Bar, > > > > Sure. There is a cmake file > https://github.com/MariaDB/server/blob/10.3/cmake/maintainer.cmake > which seems to become the place to customize GCC/Clang specific > warnings. I suppose you can add this flag there , to > MY_MAINTAINER_CXX_WARNINGS.
Thanks! This helps. I have added the flag to MY_MAINTAINER_CXX_WARNINGS. https://github.com/MariaDB/server/commit/a61fbf87ed9f6bb68332b81bc1024d1ded944d3d Greetings. > > > > Wlad > > > > *From: *Alexander Barkov <mailto:[email protected]> > *Sent: *Wednesday, December 6, 2017 12:49 PM > *To: *Vladislav Vaintroub <mailto:[email protected]>; [email protected] > <mailto:[email protected]>; maria-developers > <mailto:[email protected]> > *Subject: *-Wnon-virtual-dtor and scripts in > > > > Hello Vlad, > > > > Are we still supposed to use these scripts in the BUILD directory: > > > > compile-pentium64-debug > > compile-pentium64-debug-all > > compile-pentium64-debug-max > > compile-pentium64-gcov > > compile-pentium64-gprof > > compile-pentium64-max > > compile-pentium64-valgrind-max > > > > I stopped using them long time ago. > > But these scripts set some extra warnings for gcc, > > so now it's easy to overlook some warnings. > > > > Monty is still using these scripts and gets those extra warnings. > > > > In particular, -Wnon-virtual-dtor is often a subject of warnings. > > > > Is there a way to enable the -Wnon-virtual-dtor for gcc > > in the default build, i.e. when just using "cmake" instead of > > BUILD scripts? > > > > Thanks! > > > > > _______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp
