Hi Alexander! On Tue, Apr 10, 2018 at 12:15 PM, Alexander Barkov <b...@mariadb.com> wrote: > Hi Aleksey, > > You added Type_handler_hybrid_field_type::m_vers_trx_id. > > Is it really needed? It seems to be always "false". > So this code in aggregate_for_comparison() seems to be a dead code: > > if (m_vers_trx_id && (a == STRING_RESULT || b == STRING_RESULT)) > m_type_handler= &type_handler_datetime; > > > Can I remove m_vers_trx_id and this dead code?
Sure, please remove. Thanks! > > > Thanks! > _______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : firstname.lastname@example.org Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp