On Wed, Jan 30, 2019 at 3:50 AM Nikita Malyavin <nikitamalya...@gmail.com> wrote:
> Jan 9, 2019 06:09, Sergei Golubchik <s...@mariadb.org>: > >> > --- /dev/null >> > +++ b/mysql-test/suite/period/t/update.opt >> > @@ -0,0 +1 @@ >> > +--explicit_defaults_for_timestamp >> >> Why? >> it's best to avoid non-default command line options, unless you actually >> test this particular option. If you just need it for convenience - don't. >> >> every non-default command line options means a server restart, and >> they're slow. >> >> write DEFAULT NULL explicitly when needed. >> >> that's because DEFAULT NOW ON UPDATE NOW is implicitly added to TIMESTAMP > fields. > I did not know what to do with it first, so created MDEV-17094 to decide > what to do with it later. > Now I know -- implicit DNUN just should not be added to period fields. > I'll make a separate commit related to that task, if You don't mind > Surprisingly, the fix is already there, inside CREATE commit:) You can take a look at it in sql_table.cc changes. So i've removed the .opt file✅ -- Yours truly, Nikita Malyavin
_______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp