Hi, Aleksey! On Mar 12, Aleksey Midenkov wrote: > Hi, Sergei, > > Thank you for observations! This task is in progress. While doing it I > found out that RBR doesn't replicate timestamp fractions. That is: it > gets seconds from event timestamp marker and adds fractions from > system time. This causes bugs in System Versioning. More on it in Bug > 6 here: > https://github.com/tempesta-tech/mariadb/issues/578#issuecomment-470533050 > > I propose to fix it by adding timestamp fractions field to Log_event > header after FLAGS_OFFSET. To support backwards compatibility it is > needed to increment fdle->binlog_version and probably add new flag > LOG_EVENT_HAS_SEC_PART_F (for support sending Log_event without > fractions). > Do you agree?
Query_log_event() can already store microseconds, see Q_HRNOW flag. So better to add them to Rows_log_event, if needed. But I don't quite understand why it's needed. What you see - microseconds from the system time and seconds from the binlog event - is a workaround for replicating non-versioned master to versioned slave, where binlog events don't have microseconds. In your case versioned-to-versioned RBR, row events should have microsecond-exact timestamps already, you can get them from there. Only Delete_rows_log_event might not have the actual timestamp(6), but this can be fixed on the master, I suspect. Regards, Sergei Chief Architect MariaDB and secur...@mariadb.org _______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp
