Hi! Sergei Golubchik <s...@mariadb.org> schrieb am Mo., 26. Sept. 2022, 21:20:
> Hi, Oleksandr, > > On Sep 26, Oleksandr Byelkin wrote: > > > > LEX_STRING name; /* name for named prepared statements */ > > > > LEX *lex; // parse tree > descriptor > > > > + ulonglong ms_prepare_time; // time of preparation in microseconds > > > > > > "ms" here too :( > > > Better just say > > > > > > my_hrtime_t prepare_time; > > > > I changed everywhere to hr_ > > Yes, but you kept them ulonglong and not my_hrtime_t, why? > my_hrtime_t is a type for storing high resolution time values. > Ah, I have not noticed, will fix. > > > > > + timestamp.second_part= trigger->ms_create_time % 1000000; > > > > > > hrtime_to_time() and hrtime_sec_part() > > > > they made for events, so I made hr_time_to_time, hr_time_from_time > > What do you mean by "made for events" ? > It request val field from passed object (I mean the macro), and I am not sure if rewriting that macro a good idea. > Regards, > Sergei > VP of MariaDB Server Engineering > and secur...@mariadb.org >
_______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp
