Hello Sergei! On Wed, 3 May 2023 at 15:29, Sergei Golubchik <s...@mariadb.org> wrote:
> > you've lost the useful comment about STMT_END. > Okay. I just thought that from the reader's perspective it doesn't look important. But you are the reader, and you say it's important. Bringing back. > and you flush events for rollback too that seems like a waste. I can avoid it, but then we'll have to clear the pending event. Ok i'll do it, i think i didn't see the need to optimize these few bits of rollback. > > I personally would've kept the old structure of if()'s. > I like the new one more, as it resembles the symmetry between storing and restoring binlog's position, and besides it has fewer nesting. See my new commit b804bcbc6 <here: https://github.com/MariaDB/server/commit/b804bcbc64dfc0bc7b244eaebbd64c987bdb5a93>, or the diff with the old one, here <https://github.com/MariaDB/server/compare/c5ce597f06a...b804bcbc64dfc0bc7b244eaebbd64c987bdb5a93> . -- Yours truly, Nikita Malyavin
_______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp
