On Sat, Jan 4, 2014 at 3:17 AM, Jeffrey Kegler < [email protected]> wrote:
> I prototype every function and, as a check on the documentation's > accuracy, my build automatically creates the prototypes from the *.texi > documentation -- that way, a documentation inconsistency, hopefully, > produces a compiler warning. GCC apparently lets me get away with the > difference between an 'int' parameter and a 'const int' parameter, whereas > MS is calling me on my silliness. IIRC correctly, C90 requires that a > typedef be considered the same as its base type, so my guess is Marpa_Op vs > 'int' was not a basis for the warning. I fixed it anyway. > Great, thanks. All MS C warnings believed fixed as of commit 4c70df3. > Yep, confirmed, except for *'RETVAL' : unreferenced local variable* per this PR <https://github.com/jeffreykegler/Marpa--R2/pull/66> from this branch<https://github.com/rns/Marpa--R2/tree/fix_RETVAL_unused>. It was done (the comment says so), but left uncommitted or postponed. Overall, clean build on windows feels great, thanks a lot! -- jeffrey > ruslan > > > On 01/03/2014 02:24 PM, Ruslan Shvedov wrote: > > With all recent patches applied and RETVAL fix coming, windows build > will be warningless, except for: > > cl -c -nologo -GF -W3 -O1 -MD -Zi -DNDEBUG -DWIN32 -D_CONSOLE > -DNO_STRICT -DPERL_TEXTMODE_SCRIPTS -DPERL_IMPLICIT_CONTEXT > -DPERL_IMPLICIT_SYS -DUSE_PERLIO -D_USE_32BIT_TIME_T -DPERLDLL -O1 -MD -Zi > -DNDEBUG -DVERSION=\"5.179.103\" -DXS_VERSION=\"5.179.103\" > "-IC:\perl-5.18.1\lib\CORE" marpa_slif.c > > marpa_slif.c > > marpa_slif.w(304) : warning C4028: formal parameter 1 different from > declaration > > As the grepping below shows, this may have to do with > *marpa__slif_op_name* definitions somehow not passing from > cpan/libmarpa/slif/marpa_slif.w to derived file > cpan/libmarpa/public/marpa_slif.h:. > > > $ grep -r marpa__slif_op_name cpan/libmarpa > > cpan/libmarpa/slif/api.texi:@deftypefun const char* marpa__slif_op_name > (int @var{op_id} ) > cpan/libmarpa/slif/marpa_slif.w:marpa__slif_op_name (const Marpa_Op op_id) > > cpan/libmarpa/public/marpa_slif.h:const char* marpa__slif_op_name (int > op_id ); > cpan/libmarpa/public/marpa_slif.h.p80:const char* marpa__slif_op_name (int > op_id ); > > cpan/libmarpa/slif/marpa_slif.c:marpa__slif_op_name(const Marpa_Op op_id) > cpan/libmarpa/slif/marpa_slif.c.p50:marpa__slif_op_name(const Marpa_Op > op_id) > cpan/libmarpa/slif/marpa_slif.h.p80:const char* marpa__slif_op_name (int > op_id ); > > cpan/libmarpa/stage/marpa_slif.c:marpa__slif_op_name(const Marpa_Op > op_id) > cpan/libmarpa/stage/marpa_slif.h:const char* marpa__slif_op_name (int > op_id ); > > -- > You received this message because you are subscribed to the Google Groups > "marpa parser" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/groups/opt_out. > > > -- > You received this message because you are subscribed to the Google Groups > "marpa parser" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/groups/opt_out. > -- You received this message because you are subscribed to the Google Groups "marpa parser" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
