I gave it a skim from top to bottom, and it looks reasonable. I won't
be able to really review it until I get this current bug fix done.
It should go in before the Phase 2 rewrite starts. My plan is to get
this bug out of Phase 1, then do "inter-phase" work, in which I catch up
with all the other various things I've been pushing aside. Only once
the "inter-phase" is done and my "to do" is in shape will I proceed with
Phase 2.
Is it a pull request yet? Once you're happy with it, submit as a pull
request -- that way I won't forget it. And ignore my previous request
to submit pull requests against the "safe" branch. I'll be gathering
evertything into the "master" branch.
Thanks!! -- jeffrey
On 01/17/2014 09:14 AM, Ruslan Shvedov wrote:
Context
<https://groups.google.com/d/msg/marpa-parser/ub5ZOYF3qIQ/fgqZ5uyhu8AJ>.
I've added push_lhs to command, it returns /undef/ so far, but
otherwise seems to work -- all tests pass except sl_timeflies.t where
it is actually used, which warns on uninitialized values.
Jeffrey, can you please -- as/if time permits --code-review this
commit
<https://github.com/rns/Marpa--R2/commit/885bd19bebe628b988dbf2e566d394a199f44832> —
if it's ok or should I change something, anything before I'll start
implementing the command?
It would be good to get it done before the beginning of Phase 2 engine
rewrite, if possible.
--
You received this message because you are subscribed to the Google
Groups "marpa parser" group.
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
--
You received this message because you are subscribed to the Google Groups "marpa
parser" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
