I made comments on the commit. With regard to name vs. ID, I'd return
the ID. They might *want* the ID and if you've already converted it to
a name, they'll have to convert it back. After for the name of the
descriptor element, "lhs" vs. "lhs_id", you're closer to this, I'll let
you make the call.
-- jeffrey
On 01/18/2014 09:40 AM, Ruslan Shvedov wrote:
Context
<https://groups.google.com/d/msg/marpa-parser/ZXPPVLQ8bwE/DxeM5kmPSH4J>.
With this commit
<https://github.com/rns/Marpa--R2/commit/8e8569bbd0e6d86df9ed1c50277bb0d0d9d8500a> push_lhs
command returns the right LHS id's to the test script.
Jeffrey, can you take a look? Those comments with '-- ask' in them are
questions I'd like to ask.
The rest of the work seems to be all under cpan/(lib|t|pod) so I'm
included to a pull request if you're ok with that (this can be the
start of Phase 2) or make the changes as needed.
One big question is: the application can get the names of those LHSes
via /$slg->symbol_name($lhs_id)/, or do they need so converted in
Value.pm?
I'm currently all in favor of the former, but I'm a bit tired. :) The
option is lhs and not lhs_id, so the latter seems to be more correct.
--
You received this message because you are subscribed to the Google
Groups "marpa parser" group.
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
--
You received this message because you are subscribed to the Google Groups "marpa
parser" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
