Hello,

I have checked out the Java sources of release 0.7 and I am surprised
to see that there are so many warnings raised by Eclipse for them.

For example, in MartShellLib.java, lines 362-364 read:
    //String handler = filter.getHandler();
    String handler = null;
    if (handler.equals(IDListFilter.FILE)) {

Surely, this is a genuine mistake. Eclipse also reports many unused
variables, i.e. assignments to variables which are never read.

Besides that, there are peculiar catch-cases, for example, in
MartEditor in uploadAll() there are two instances of:
    } catch (Exception e) {
        e.printStackTrace();
    }

Should there not be a dialog for that as it is the case of
ConfigurationException-s in the very same method?

I also found that org.ensembl.util.StringUtil is missing from the CVS
repository, whilst it is present in the JAR-file of the mart tools.
The class is used by org.ensembl.mart.lib.Query and
org.ensembl.mart.util.StringUtil.

Since the code from the CVS repository does not compile, I assume
there is an inofficial official-repository for the source code
somewhere? Would it be possible to bring the source code of the 0.7
release up to speed, so that it represents the code actually used to
build the mart tools?

Thanks and Best Wishes,
Joachim

-- 
B.1079 Michael Smith Building
Faculty of Life Sciences
The University of Manchester
Oxford Road
Manchester
M13 9PT
United Kingdom

Reply via email to