[
https://wso2.org/jira/browse/MASHUP-771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16381#action_16381
]
Keith Godwin Chapman commented on MASHUP-771:
---------------------------------------------
Fixed. This went in as several commits. The final fix went in revision 16134.
> Incorparate code review comments into JSDeployer (and related classes)
> ----------------------------------------------------------------------
>
> Key: MASHUP-771
> URL: https://wso2.org/jira/browse/MASHUP-771
> Project: WSO2 Mashup Server
> Issue Type: Improvement
> Reporter: Keith Godwin Chapman
> Assignee: Keith Godwin Chapman
> Fix For: 1.1
>
>
> 1) Remove 'mashup constants' interface, make into a class.
> 2) Consistant commenting standards - space afer //
> 3) When catering for 'multitple custom deployers' exceptions at init should
> not stop the server starting. Throw a checked exception, so it can be handled.
> 4) Change us to userStoreAdmin
> 5) Methods like initRegistry, deploy and other such long method should be
> analyzed as they may be doing more than one discrete function, in which case
> they should be refactored.
> 6) schemaTargetNamespace, XSD, etc. - basically all string literals can be
> made constants
> 7) User axis2 constants where possible (SMTP, XMPP, etc.)
> 8) "const".equals() to avoid null pointer exceptions
> 9) Null check and set to upper case for prefix
> 10) Check for existance 'convertToString' or better, qualify with wso2_ prefix
> 11) Registry initialization should ideally be in a separate, static class.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://wso2.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
Mashup-dev mailing list
[email protected]
http://www.wso2.org/cgi-bin/mailman/listinfo/mashup-dev
