Author: keith
Date: Mon Apr 28 10:18:43 2008
New Revision: 16289
Log:
Avoid using string concaternation and using stringBuffer instead. (This has a
performance advantage as suggested by findbugs)
Modified:
trunk/mashup/java/modules/core/src/org/wso2/mashup/utils/MashupArchiveManupulator.java
trunk/mashup/java/modules/core/src/org/wso2/mashup/utils/MashupUtils.java
trunk/mashup/java/modules/core/src/org/wso2/mashup/webapp/userprofile/User.java
trunk/mashup/java/modules/core/src/org/wso2/mashup/webapp/userprofile/UserQuery.java
trunk/mashup/java/modules/core/src/org/wso2/mashup/webapp/utils/QueryParamUtils.java
Modified:
trunk/mashup/java/modules/core/src/org/wso2/mashup/utils/MashupArchiveManupulator.java
==============================================================================
---
trunk/mashup/java/modules/core/src/org/wso2/mashup/utils/MashupArchiveManupulator.java
(original)
+++
trunk/mashup/java/modules/core/src/org/wso2/mashup/utils/MashupArchiveManupulator.java
Mon Apr 28 10:18:43 2008
@@ -159,13 +159,14 @@
UserRegistry systemRegistry =
embeddedRegistry.getSystemRegistry();
Tag[] tags = systemRegistry.getTags(mashupPath);
if (tags != null && tags.length > 0) {
- String tagString = "<tags>";
+ StringBuffer buffer = new StringBuffer();
+ buffer.append("<tags>");
for (int i = 0; i < tags.length; i++) {
Tag tag = tags[i];
- tagString = tagString + "<tag>" + tag.getTagName() +
"</tag>";
+
buffer.append("<tag>").append(tag.getTagName()).append("</tag>");
}
- tagString = tagString + "</tags>";
- byteArrayInputStream = new
ByteArrayInputStream(tagString.getBytes());
+ buffer.append("</tags>");
+ byteArrayInputStream = new
ByteArrayInputStream(buffer.toString().getBytes());
}
} catch (RegistryException e) {
throw new MashupFault(
Modified:
trunk/mashup/java/modules/core/src/org/wso2/mashup/utils/MashupUtils.java
==============================================================================
--- trunk/mashup/java/modules/core/src/org/wso2/mashup/utils/MashupUtils.java
(original)
+++ trunk/mashup/java/modules/core/src/org/wso2/mashup/utils/MashupUtils.java
Mon Apr 28 10:18:43 2008
@@ -658,11 +658,11 @@
//Extracting the real path from the registry path provided
String[] pathContents = decodedServicePath.split("/");
- decodedServicePath = "";
+ StringBuffer buffer = new StringBuffer();
for (int x = 2; x < pathContents.length; x++) {
- decodedServicePath = decodedServicePath + "/" +
pathContents[x];
+ buffer.append("/").append(pathContents[x]);
}
-
+ decodedServicePath = buffer.toString();
serviceName = pathContents[3];
MashupUtils.validateName(serviceName, "ServiceName");
} catch (MashupFault e) {
Modified:
trunk/mashup/java/modules/core/src/org/wso2/mashup/webapp/userprofile/User.java
==============================================================================
---
trunk/mashup/java/modules/core/src/org/wso2/mashup/webapp/userprofile/User.java
(original)
+++
trunk/mashup/java/modules/core/src/org/wso2/mashup/webapp/userprofile/User.java
Mon Apr 28 10:18:43 2008
@@ -93,19 +93,20 @@
*/
public String serializeUserProfile() {
// todo: use a real XML parser and extend the format into UserQuery
for easy extensibility of properties.
- String userProfileString = "<profile>";
+ StringBuffer userProfile = new StringBuffer();
+ userProfile.append("<profile>");
//Setting nickName
- userProfileString = userProfileString + "<username>" +
escape(getUsername()) + "</username>";
+
userProfile.append("<username>").append(escape(getUsername())).append("</username>");
//setting User bio
- userProfileString = userProfileString + "<bio>" + escape(getBio()) +
"</bio>";
+ userProfile.append("<bio>").append(escape(getBio())).append("</bio>");
//adding Email address
- userProfileString = userProfileString + "<email>" +
escape(getEmailAddress()) + "</email>";
+
userProfile.append("<email>").append(escape(getEmailAddress())).append("</email>");
for (int i = 0; i < queries.size(); i++) {
UserQuery userQuery = (UserQuery) queries.get(i);
- userProfileString = userProfileString + "<query>" +
userQuery.toString() + "</query>";
+
userProfile.append("<query>").append(userQuery.toString()).append("</query>");
}
- userProfileString = userProfileString + "</profile>";
- return userProfileString;
+ userProfile.append("</profile>");
+ return userProfile.toString();
}
private String escape(String xml) {
xml = xml.replaceAll("&", "&");
Modified:
trunk/mashup/java/modules/core/src/org/wso2/mashup/webapp/userprofile/UserQuery.java
==============================================================================
---
trunk/mashup/java/modules/core/src/org/wso2/mashup/webapp/userprofile/UserQuery.java
(original)
+++
trunk/mashup/java/modules/core/src/org/wso2/mashup/webapp/userprofile/UserQuery.java
Mon Apr 28 10:18:43 2008
@@ -114,14 +114,14 @@
private String getQueryParametersAsString() {
String[] queryparameters = getQueryParameters();
- String value = "";
+ StringBuffer buffer = new StringBuffer();
if (queryparameters != null) {
for (int i = 0; i < queryparameters.length; i++) {
String queryparameter = queryparameters[i];
- value = value + "|" + queryparameter;
+ buffer.append("|").append(queryparameter);
}
}
- return value;
+ return buffer.toString();
}
public int getQueryType() {
Modified:
trunk/mashup/java/modules/core/src/org/wso2/mashup/webapp/utils/QueryParamUtils.java
==============================================================================
---
trunk/mashup/java/modules/core/src/org/wso2/mashup/webapp/utils/QueryParamUtils.java
(original)
+++
trunk/mashup/java/modules/core/src/org/wso2/mashup/webapp/utils/QueryParamUtils.java
Mon Apr 28 10:18:43 2008
@@ -58,14 +58,14 @@
}
public static String paramsToString(String[] params) {
- String value = "";
+ StringBuffer buffer = new StringBuffer();
if (params != null) {
for (int k = 0; k < params.length; k++) {
- if (k != 0) value += "|";
- value += params[k];
+ if (k != 0) buffer.append( "|");
+ buffer.append(params[k]);
}
}
- return value;
+ return buffer.toString();
}
public static String paramsFromQuery(String path, String[] params) {
_______________________________________________
Mashup-dev mailing list
[email protected]
http://www.wso2.org/cgi-bin/mailman/listinfo/mashup-dev
