Hello,
Gautam Iyer a écrit : > The HAVE_LIBX11 is a real dependency. See configure.ac:873 for the lines > that generate it. They die if the library is not found. > > Any references to HAVE_LIBX11 in the code can safely be removed, or > replaced with > > #ifdef HAVE_LIBX11 > /* code here */ > #else > # error "Mrxvt needs libX11 to compile (and run)" > #endif > Ok perfect for the X11 lib knowing it is mandatory! I was just getting tired of thinking there was some other way for mrxvt to run than X and having to look for alternate method for all these other ways! :p If you don't mind, rather than making your "complicated" #ifdef #else, I would rather remove all "HAVE_LIBX11" reference. As it is a real mandatory dependency, user must have it, and they won't be able to pass the configure state anyway (and even by somehow bypass it, it will fail at the include). So for readability, and avoiding developers (like me!) to wonder stupidely "is X optional for mrxvt?", I will just use all the X function directly (at least the one which must be in all X versions). > Feel free to use any function in libX11. I'm 99% sure you can also use > libXext. At any rate, if there's some library you want to use functions > from (for UTF8 support) feel free -- Just be sure you #ifdef the code, > so that people without the library are not forced into installing it. > Yes, of course, if I use an optional method. But I will try to avoid such as much as possible (making ten methods with ifdef for each step is really boring and hard to maintain code, at least I think). For the libXext, I did not know it, I will have a look. Jehan > GI > > > > ------------------------------------------------------------------------ > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > > > ------------------------------------------------------------------------ > > _______________________________________________ > Materm-devel mailing list > Materm-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/materm-devel > mrxvt home page: http://materm.sourceforge.net ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Materm-devel mailing list Materm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/materm-devel mrxvt home page: http://materm.sourceforge.net
