Signed 'single' bit can have only two states: 0, -1 we had a
"overflow in implicit constant conversion" if we assign it a value of 1.
This issue is not present if is not defined __GNUC__ because we don't
use bit-fields at all.
NOTE: I think it was better to remove bit fields from the code to avoid
compiler implementation dependency (cfr. ISO/IEC 9899:1999) and,
as far as I see from a little test the code size gain using bit-fields
as stated in the ISO standard, as GCC extension or none is very little
or even worse.
Roberto.
---
src/rxvtlib.h | 2 +-
src/xdefaults.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/rxvtlib.h b/src/rxvtlib.h
index cf519ab..af52477 100644
--- a/src/rxvtlib.h
+++ b/src/rxvtlib.h
@@ -97,7 +97,7 @@ typedef struct
uint16_t lineSpace; /* space between rows */
#endif
- char BOOLVAR(focus,1); /* window is focused? */
+ unsigned char BOOLVAR(focus,1); /* window is focused? */
char enter; /* pointer is in window? */
Window parent; /* parent window */
diff --git a/src/xdefaults.c b/src/xdefaults.c
index 0513676..85ff94f 100644
--- a/src/xdefaults.c
+++ b/src/xdefaults.c
@@ -95,7 +95,7 @@ static const struct {
const char* arg; /* argument */
const char* desc; /* description */
- const char BOOLVAR( multiple, 1 ); /* multiple values for profiles */
+ const unsigned char BOOLVAR( multiple, 1 ); /* multiple
values for profiles */
} optList[] = {
/* Options for each profile */
#ifdef BACKGROUND_IMAGE
--
1.6.1.3
------------------------------------------------------------------------------
Benefiting from Server Virtualization: Beyond Initial Workload
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve
application availability and disaster protection. Learn more about boosting
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
_______________________________________________
Materm-devel mailing list
Materm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/materm-devel
mrxvt home page: http://materm.sourceforge.net
