>>> "KC" == Karthik Chikmagalur <karthikchikmaga...@gmail.com> writes:

> Hi Eric,
> The `matlab-local-xref` backend is quite useful, thank you for taking
> the time to go through it. I did notice something in this function:

> (defun matlab-shell-xref-activate ()
>   "Function to activate xref backend.
> Add this function to `xref-backend-functions' for matlab shell to
> use xref to find function and variable definitions."
>   (and (member major-mode '(matlab-mode matlab-shell-mode org-mode))
>        (matlab-shell-active-p)
>        'matlab-shell))

> The test for major-mode is unnecessary since the xref backend is only
> loaded when matlab-mode is activated. Even if you decide to leave it in
> the reference to `org-mode' is completely superfluous. This is some
> debug code that I forgot to take out before I submitted the patch. (The
> same applies to the function `matlab-local-xref-activate'.) So we just
> need

Sorry for jumping into the discussion (and almost knowing nothing about
xref), I do use org mode to execute matlab code via babel and I am sure
other users as well. 

Does this in  anyway influence the part

>   (and (member major-mode '(matlab-mode matlab-shell-mode org-mode))

You were just talking about?

Attachment: smime.p7s
Description: S/MIME cryptographic signature

_______________________________________________
Matlab-emacs-discuss mailing list
Matlab-emacs-discuss@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/matlab-emacs-discuss

Reply via email to