>>> "JCvM" == Julien Claisse via Matlab-emacs-discuss >>> <matlab-emacs-discuss@lists.sourceforge.net> writes:
Hi Julien,
> Hi,
> First, thanks to the developer team for maintaining this emacs package. I'm
> using it almost every day.
Most of the work is done by Eric and John.
> I'm sending this mail because I want to suggest one improvement in the
> emacsrunregion.m matlab function for being able to use it into a tramp
> opened file (I'm also doing a lot of remote development on several targets).
> This improvement is relatively straightforward, it adds the following lines
> at the beginning of the function :
> modified toolbox/emacsrunregion.m
> @@ -2,6 +2,12 @@ function emacsrunregion(file, startchar, endchar)
> % Run code from FILE between STARTCHAR and ENDCHAR.
> % Command sent by Emacs for run-cell & run-region functionality.
> + % Filter out emacs tramp file path prefix
> + trampMatch = regexp(file, {'/*:',':/'});
> + if (~isempty(trampMatch{1}))
> + file = file((trampMatch{2}+1):end);
> + end
> +
> if ~exist(file,'file')
> error('You must save your region into a file accessible by MATLAB
> process.');
> end
> This way, file tramp path prefixes like "/scp:host@host_ip:" are filtered
> out and the MATLAB remote shell can find the file without any trouble.
That looks ok to me, but since this is Eric's brainchild,
I think he should also agree.
> How can I submit this pull request ? Do I simply need to commit and push ?
Commit and push to where?
The main development is done in sourceforge, github is just a mirror. I
am not sure whether you have write access to sourceforge I rather think
not.
I not a huge fan of pull request[1] although I know most people consider it
today as a standard.
Once we agreed on that patch I can apply it to Master, or Eric for that
matter.
Regards
Uwe
Footnotes:
[1] I prefer to discuss patches on the mailing list and then apply them
or to give a person write access to that he/she can push.
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ Matlab-emacs-discuss mailing list Matlab-emacs-discuss@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/matlab-emacs-discuss
