Andrew,
This looks very cool, and I'm looking forward to playing around with
it. Thanks for the hard work!
Shooting from the hip, here are some initial comments. I may be able
to submit patches for some of the more innocuous items later in the
week.
1. It appears that as_sizer_element() uses the _axes_sizer_elements
dictionary to cache MplAxesSizerElement instances. Using a
WeakKeyDictionary from the "weakref" module instead of a regular
dictionary may be necessary to allow the garbage collection of the
MplAxesSizerElements when their associated Axes gets GC'd.
2. Convenience MplBoxSizer subclasses that let you omit the "orient"
keyword might be nice:
class MplHBoxSizer(MplBoxSizer):
def __init__(self):
MplBoxSizer.__init__(self, orientation='vertical')
3. Couldn't you just drop mplsizer.py into the "matplotlib.toolkits"
virtual package? Maybe you can't -- I'm pretty new to applied python-
eggery.
4. I feel we should avoid the whole European/American spelling
problem that WX has. Why not make both 'align_centre' and
'align_center' do the same thing?
5. Why not use shorter names, with less redundancy? (e.g.
"matplotlib.toolkits.sizer", FigureSizer, Box, HBox, Grid, etc)
Ken
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Matplotlib-devel mailing list
Matplotlib-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
