On Dec 16, 2007 9:10 PM, John Hunter <[EMAIL PROTECTED]> wrote: > On Dec 16, 2007 5:26 PM, Andrew Straw <[EMAIL PROTECTED]> wrote: > > > As a followup to the work on floats, I fixed rec2csv to deal with funky > > strings (strings with commas and quotes). I've checked this is as r4749, > > but I thought I'd announce here in case someone (John, in particular) > > was depending on some peculiar aspect of the old implementation. If > > there is something you depend on, can you update the unittests in > > unit/mlab_unit.py to check for the behavior you need? > > > > Also, John, I didn't see mlab.FormatString being used anywhere, but I > > didn't want to change it, either. So I made FormatString2 and used it. > > But if there's no known use of FormatString, lets kill the original and > > more FormatString2 into its place. > > I am happy to leave it as is, and fix it if I bump into anything. > There was a use case at work that made me quote all the strings with " > but I am not sure what it is right now so I will test with your > version tomorrow and see if I can find any problems. > > There is one more thing I'd like to clean up in this code, and that is > the handling of date and datetime. The current implementation will > return datetime regardless of whether the string looks like a date or > a datetime. Thus it would fail a roundtrip tests if you had a date > field. I may make some changes tomorrow to support date or datetime.
I'm CCing Chris Burns, from Berkeley here, but it would be great if you post a note of these changes on the numpy list. One of the things to come out of the sprint was a lot of work on numpy i/o, and that includes looking into integrating much of the MPL facilities. So it would be great if you keep the numpy team posted, to make sure they get your latest code. Cheers. > > What do you think of making checkrows=0 the default for csv2rec? It > is slower, but mostly guaranteed to do the right thing, whereas > checkrows=5 which is the current default can often fail if the first 5 > rows match some type but later rows do not, and may lead to confusion > among new users. ------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace _______________________________________________ Matplotlib-devel mailing list Matplotlib-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
