Fernando Perez wrote the following on 04/17/2008 06:31 PM:
> ps - for now, using the deprecated 'faceted=False' seems to still
> work, so I'll go with that.
I noticed this a few days ago as well...using edgecolors='None' seemed
to have the same effect as faceted=False. This brings up a couple issues.
1) I find the shading=* in the docstring to be a bit confusing. The
equal sign makes me think of keyword arguments. Since 'shading' is not a
valid keyword, additional clarity might result if we do not use the
equal sign.
2) If we remove the equal signs, we might have something like this:
This kwarg is deprecated;
please use the edgecolors kwarg instead:
flat shading --> edgecolors='None'
faceted shading --> edgecolors=None
But even this is confusing. Reading
http://www.physnet.uni-hamburg.de/physnet/matlab/help/techdoc/ref/shading.html
makes me think we should have:
This kwarg is deprecated;
please use the edgecolors kwarg instead:
flat shading --> edgecolors=None
For faceted shading, edgecolors can be any mpl color or sequence
of colors.
---
So it seems like the code is working, but that the docstring is wrong.
Perhaps the behavior should be changed so that edgecolors must be set to
None rather than 'None' when requesting flat shading.
~C
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
Matplotlib-devel mailing list
Matplotlib-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
