John Hunter wrote:
> On Wed, Apr 2, 2008 at 6:39 PM, Erik Tollerud <[EMAIL PROTECTED]> wrote:
> 
>>  are slightly different).  There's a slight compatibility issue in that
>>  as it stands in that the returned tuple now has 4 values (I added a
>>  list of the lines that are generated if the steps command is used),
>>  but I can't really imagine how that could break anything but the
>>  poorest-written code...
> 
> I'm not sure I understand this: won't it break all code written like:
> 
>   n, bins, patches = ax.hist(x, 50, normed=1)
> 
> which is the code presented in the histogram example and a fairly
> common approach.  I don't see this as an example of the "poorest
> written code".    I am inclined to not break this call signature
> unless the lines are actually used, ie 'step' in histtype.  On a quick
> read of the code, you either get lines or patches but not both, so how
> about
> 
>     n, bins, patches = ax.hist(x, 50, normed=1)
> 
> or
> 
>    n, bins, lines = ax.hist(x, 50, normed=1, histtype='lines')

That was my first reaction also, but the proposed "stepfill" option 
yields a bunch of bar patches *and* a line.  The solution may be to 
accomplish "stepfill" with two separate calls, or to have 4 outputs only 
in the "stepfill" case.  Or, with sufficient rewriting I think the 
"stepfill" case could yield a single patch and a single line, and the 
third output in this case could be a single corresponding 2-element 
tuple or list.  That is, the third output is considered simply a list of 
artists.  Now I will stop speculating and leave it to Manuel to sort out.

Eric

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
Matplotlib-devel mailing list
Matplotlib-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/matplotlib-devel

Reply via email to