John Hunter wrote: > Manuel and Michael worked on fixing a bug with TextWithDash, but this > introduced a bug will all tick labels so I reverted the changes. The > problem is that the text layout code in Text (eg draw, > get_window_extent) is using "get_position" which in TextWithDash is > the dash position, according to the doc string and the original impl. > On the branch, the draw and layout methods of Text use _get_xy_display > which TextWithDash overrides. That is why it works on the branch and > not the trunk. The changes of M&M to make set_position and > get_position refer to the x and y locs fixed dash with text for > reasons that are not completely clear t me, but broke tick labels > which are also TextWithDash instances. > > I did not write TextWithDash so cannot vouch for its conventions, but > I don't have time to dig deeply enough right now to fix this, so I > wanted to revert the changes so regular plots would work again and > give a head's up here so Manuel, Michael and I would not be doing and > undoing each other's changes w/o some understanding of where the > discerpancy was arising.
Hm, the patch I applied was exactly because I got also problems with the tick labels -- they were all squashed to one place -- and I thought to have fixed that. Now, it seems this wasn't quite correct ;-) As I have also no deeper understanding what's _really_ going on in TextWithDash, I will now better keep my hands off TextWithDash ... Manuel > Thanks, > JDH > > ------------------------------------------------------------------------- > Check out the new SourceForge.net Marketplace. > It's the best place to buy or sell services for > just about anything Open Source. > http://sourceforge.net/services/buy/index.php > _______________________________________________ > Matplotlib-devel mailing list > Matplotlib-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/matplotlib-devel ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ Matplotlib-devel mailing list Matplotlib-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
