John Hunter wrote: > On Fri, Jul 25, 2008 at 7:02 PM, Eric Firing <[EMAIL PROTECTED]> wrote: > >> This looks incomplete--shouldn't the QuiverKey initializer be using this >> function to set the figure from Q.ax.figure, and then should be using >> self.figure to get the transform? >> >> I don't want to jump in if you are in the middle of working with it, though. >> I don't know what your motivation for adding this function was. > > All artists which contain other artists (eg QuiverKey contains a Text > instance) should override set_figure to pass the figure on to the > childen (we should have an ArtistContainer base class to facilitate > stuff like this). When we later call ax.add_artist(quiverkey), the ax > instance will call quiverkey.set_figure so the figure will get passed > down to the Text. I needed to get the figure instance set on the text > instance because the Text prop key method was using the renderer dpi > instance in the cache key, and renderer.dpi no longer exists. Now I > am not nearly as familiar with QuiverKey as you are, but this was just > a simple fix to make sure the quiverkey text instance gets its figure > set. If it appears to you that something is still missing, please > clarify.
Thanks for the explanation. The change I had in mind would not hurt, but it would not help, either, so we'll leave it out. Eric ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Matplotlib-devel mailing list Matplotlib-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
