On Tue, Oct 21, 2008 at 3:31 AM, Manuel Metz <[EMAIL PROTECTED]> wrote:
> David Huard wrote:
>> On Mon, Oct 20, 2008 at 10:19 AM, John Hunter <[EMAIL PROTECTED]> wrote:
>>> On Mon, Oct 20, 2008 at 9:01 AM, David Huard <[EMAIL PROTECTED]> wrote:
>>>
>>>> I would oppose any change to histogram calling convention that does not
>>>> fix a critical bug. I agree that using a built-in name as an argument is
>>>> a bug, but I believe it is the lesser evil compared to asking users to
>>>> change their code
>>>> again.
>>
>> It may not have been clear enough, but let me clarify that I was
>> opposing a change to numpy.histogram, not meddling in matplotlib's
>> hist.
>
> David,
>
> the only thing is that *if* we change the keyword in matplotlib, we
> should change it to the same keyword that will (probably) be in numpy.
>
> Put it the other way: I think it would be good to agree on a new keyword
> ("binrange", "cliprange", ...) and then change it gently in both
> projects, numpy and matplotlib, as John suggested (or alternatively
> leave the keyword as is, and use the arange workaround, but I personally
> don't like this idea).
>
> Cheers,
> Manuel
>
Hi Manuel, John and Eric,
What was the time line you had in mind for the change ?
My main concern is to avoid antagonizing the folks who were annoyed by
the semantic change to histogram. Some of them might not be happy to
go back and make another change to histogram in their code so soon
after having dealt with the `new` keyword, even if you are gentle
about it.
My second concern is to avoid breaking the interface in a minor
release. This would mean waiting for NumPy 2.0 before completely
removing the range argument.
David
>> Cheers,
>> David
>>
>>> I think in this case we have to change it, but we can do it gently.
>>> Ie, for a release cycle, if we detect "range" in the kwarg case, we'll
>>> set the correct kwarg, eg "binrange", issue a warning, but not raise
>>> an error. That way users can fairly easily change their code w/o
>>> breakage. Whoever does the deprecation should note the date and
>>> version of the deprecation warning, so we will know when enough time
>>> and releases have passed to remove range entirely.
>>>
>>> JDH
>>>
>>
>
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Matplotlib-devel mailing list
> Matplotlib-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
>
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Matplotlib-devel mailing list
Matplotlib-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
