Eric, I was looking at it from the perspective of most of the other API calls throughout matplotlib have the Axes or Axis as the first argument. Typically this is because it is what wants the work to be done or is being worked on. I was just following suit. I can see where you are coming from. I have no real strong argument for or against, so if I should swap them around as you had suggested, then I have no problem changing it.
--James > -----Original Message----- > From: Eric Firing [mailto:efir...@hawaii.edu] > Sent: Wednesday, January 28, 2009 10:48 AM > To: James Evans > Cc: 'matplotlib development list' > Subject: Re: [matplotlib-devel] Updated units.ConversionInterface > > James Evans wrote: > > All, > > > > I have just submitted an updated units.ConversionInterface. For each of > > the static methods it now > takes the invoking Axis instance > > as a parameter. I have updated the appropriate calling functions. This > > allows the DateConverter to > now guarantee that the default > > axes no longer attempts to convert a value of zero to a date (ie. The > > 'ordinal <= 0' datetime > conversion error is now a lot more > > difficult to invoke). Additionally I have modified the DateConverter class > > to make use of any > specified units, such that the > > timezone is used for the units value. > > > > James, > > I have not thought all this through, but a quick look at your changeset > raises the question: > > Why are you making such a complete change in the API? In every > instance, you are changing the method signature so that the new arg, > "axis", is the first. This seems particularly odd for the "convert" > method--the new signature, convert(axis, value, unit), gives the > arguments in what seems to be an unintuitive order. Why not have > something like convert(value, unit, axis=None), so that convert can be > called without specifying an axis, and so that the argument order is > still natural: "convert the value with unit, taking advantage of the > axis if specified"? > > Is there some compelling logic to having the "axis" argument now at the > head of the list? > > Eric > > > --James Evans > > > > PS: I expect to be submitting a fully functioning test harness by the end > > of this week. > > > > > > ------------------------------------------------------------------------------ > > This SF.net email is sponsored by: > > SourcForge Community > > SourceForge wants to tell your story. > > http://p.sf.net/sfu/sf-spreadtheword > > _______________________________________________ > > Matplotlib-devel mailing list > > Matplotlib-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/matplotlib-devel ------------------------------------------------------------------------------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword _______________________________________________ Matplotlib-devel mailing list Matplotlib-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
