I just had a quick at the patch and it looks good. I have two minor issues.
1) API change in Axes.get_xaxis_transform & get_yaxis_transform. The default keyword argument which=None raises an exception. Maybe you meant which="grid"? 2) Axes.frame Is it okay to simply drop this attribute? Any code that access this attribute will raise an exception. For example, some of my code in mpl_toolkits.axes_grid access this attribute, although a fix would be very trivial. Regards, -JJ On Thu, May 21, 2009 at 8:06 PM, Andrew Straw <straw...@astraw.com> wrote: > I've implemented initial support for "dropped spines". This is motivated > by the ability to draw figures that look like > http://jeb.biologists.org/cgi/content/full/211/3/341/FIG7 . I'm > attaching the patches and an image created by the new example. > > This is a somewhat invasive change into the core of the axis rendering > code, so I'm hereby requesting a review before committing it into the > code base. In particular, I dropped the idea of using Traits in MPL not > because I think it's a bad idea, but because that would involve more > substantial changes. > > Anyhow, I'm attaching the proposed implementation as a series of > patches. If the general form of this looks OK, I'd write up doc strings > and a CHANGELOG entry and commit it. Should I wait until after the trunk > release? > > Please let me know what you think. All the examples run with > exaples/tests/backend_driver.py still seem to give OK results, and the > test suite raises a few more failures, but these appear due to > (sub)pixel shifts in text rendering rather than anything more severe. > > -Andrew > > ------------------------------------------------------------------------------ > Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT > is a gathering of tech-side developers & brand creativity professionals. Meet > the minds behind Google Creative Lab, Visual Complexity, Processing, & > iPhoneDevCamp asthey present alongside digital heavyweights like Barbarian > Group, R/GA, & Big Spaceship. http://www.creativitycat.com > _______________________________________________ > Matplotlib-devel mailing list > Matplotlib-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/matplotlib-devel > > ------------------------------------------------------------------------------ Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT is a gathering of tech-side developers & brand creativity professionals. Meet the minds behind Google Creative Lab, Visual Complexity, Processing, & iPhoneDevCamp asthey present alongside digital heavyweights like Barbarian Group, R/GA, & Big Spaceship. http://www.creativitycat.com _______________________________________________ Matplotlib-devel mailing list Matplotlib-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
