Andrew Straw wrote:
> Thanks everyone for the feedback. I have made Spine subclass Patch in
> svn r7170, which I just committed.  This resulted in a slight API
> change, but addresses most of the more substantial points raised.
> 
> The slight API change is that spine.set_color() is now
> spine.set_edgecolor().

But spine.set_color() is much more natural and easy to remember, so 
maybe it can be restored:

Collections have had a set_color() for a long time, and I don't see any 
reason Patch shouldn't have the same, so I added it.  My first thought 
was that this would have no effect on spines except to permit the 
alternative and more natural "spine.set_color()" to work like 
set_edgecolor, but now I see that this is not true--in the case of a 
circular spine, calling set_color(c) would have the unintended effect of 
filling the circle.  I still think having the set_color method in Patch 
and Spine is good, so what I propose is that Spine override the Patch 
version with a simple alias to set_edgecolor.

Eric

------------------------------------------------------------------------------
OpenSolaris 2009.06 is a cutting edge operating system for enterprises 
looking to deploy the next generation of Solaris that includes the latest 
innovations from Sun and the OpenSource community. Download a copy and 
enjoy capabilities such as Networking, Storage and Virtualization. 
Go to: http://p.sf.net/sfu/opensolaris-get
_______________________________________________
Matplotlib-devel mailing list
Matplotlib-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/matplotlib-devel

Reply via email to