On Thu, Aug 6, 2009 at 2:03 PM, John Hunter <jdh2...@gmail.com> wrote:

> On Thu, Aug 6, 2009 at 1:59 PM, Ryan May<rma...@gmail.com> wrote:
> > On Thu, Aug 6, 2009 at 1:55 PM, John Hunter <jdh2...@gmail.com> wrote:
> >>
> >> On Thu, Aug 6, 2009 at 1:50 PM, Ryan May<rma...@gmail.com> wrote:
> >> >
> >> > On Thu, Aug 6, 2009 at 1:38 PM, Gökhan Sever <gokhanse...@gmail.com>
> >> > wrote:
> >> >>
> >> >> Shouldn't colorbar_doc name be hidden from users? It doesn't look
> like
> >> >> the
> >> >> rest other function documentation in pyplot.py file.
> >> >>
> >> >> In [10]: color
> >> >> colorbar      colorbar_doc  colormaps     colors
> >> >
> >> > Good catch.  Fixed in 7406.
> >>
> >> Just reading this, it looks like you missed the import
> >> matplotlib.colorbar part, no?  Or am I missing something?
> >
> > On my machine, the import didn't seem to be necessary.
> matplotlib.colorbar
> > is available just with:
> >
> >     import matplotlib
>
> Strange...
>
>  j> python
>  Python 2.4.5 (#4, Apr 12 2008, 09:09:16)
>  [GCC 3.4.1] on sunos5
>  Type "help", "copyright", "credits" or "license" for more information.
>  >>> import matplotlib
>  >>> matplotlib.colorbar
>  Traceback (most recent call last):
>    File "<stdin>", line 1, in ?
>  AttributeError: 'module' object has no attribute 'colorbar'
>  >>> matplotlib.__version__
>  '1.0.svn'
>

Stranger still (or it is to me):

Python 2.6.2 (r262:71600, Aug  3 2009, 10:34:14)
[GCC 4.3.2] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import matplotlib
>>> matplotlib.colorbar
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'module' object has no attribute 'colorbar'
>>> from matplotlib import pyplot
>>> matplotlib.colorbar
<module 'matplotlib.colorbar' from
'/home/rmay/.local/lib/python2.6/site-packages/matplotlib/colorbar.pyc'>


>
> > Would it be better to explicitly import matplotlib.colorbar anyways?
>
> Yes
>

Clearly.

>> When possible, could you make bugfixes to the branch and merge to the
>> trunk?  I know this is a bit of a hassle, but we often live on a
>> release branch for several bug fix release cycles, so it is nice to
>> put the simple fixes there
>>
>> http://matplotlib.sourceforge.net/devel/coding_guide.html
>
> Yeah, my bad.  I just remembered after committing to trunk and was working
> on checking out the new branch and applying there when you made your fix.
> So what n ow?

Ahh, now the pain begins.  I believe the easiest path is to put the
> change in the branch, svn commit, go over to the trunk, svnmerge,
> resolve any conflicts and commit.  Now wasn't that easy?


I remember doing this before now.  I don't think there will be any problems
with making the changes outside of svnmerge.  The alternative is to change
trunk back and use svnmerge.  I don't mind doing either.  Got a preference
on which way to handle colorbar_doc?

Ryan

-- 
Ryan May
Graduate Research Assistant
School of Meteorology
University of Oklahoma
Sent from Norman, Oklahoma, United States
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Matplotlib-devel mailing list
Matplotlib-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/matplotlib-devel

Reply via email to