Yes I tried without path simplification, and I don't get any crashes. If we
need to support older versions of cairo / pycairo, I suggest that we have the
path length check after checking the version of cairo / pycairo, and that we
perform the path length check after path simplification, so we know how many
points will actually be drawn.
--Michiel.
--- On Mon, 2/22/10, Eric Firing <efir...@hawaii.edu> wrote:
> From: Eric Firing <efir...@hawaii.edu>
> Subject: Re: [matplotlib-devel] Path length in the cairo backend
> To: "Michiel de Hoon" <mjldeh...@yahoo.com>
> Cc: matplotlib-devel@lists.sourceforge.net
> Date: Monday, February 22, 2010, 1:00 PM
> Michiel de Hoon wrote:
> > Dear all,
> >
> > The draw_path method in backend_cairo.py starts with a
> check for the number of vertices in the path, and raises an
> error if the path contains more than 18980 vertices:
> >
> > def draw_path(self, gc, path,
> transform, rgbFace=None):
> > if
> len(path.vertices) > 18980:
> > raise
> ValueError("The Cairo backend can not draw paths longer than
> 18980 points.")
> >
> > This was needed in the past when cairo version 1.4.10
> / pycairo version 1.4.0 would segfault:
> >
> > http://sourceforge.net/mailarchive/message.php?msg_name=487E2E78.1050501%40stsci.edu
> >
> > However, we're now at cairo, pycairo version 1.8.8,
> and I haven't seen any segfaults after removing this check.
> >
>
> Is path simplification in effect? If so, have you
> tested after turning simplification off, so that you can be
> sure how many points cairo is trying to plot?
>
> Eric
>
>
> > Does anybody object if I remove this check from the
> code?
> >
> > --Michiel.
> >
> >
> >
> >
> >
> ------------------------------------------------------------------------------
> > Download Intel® Parallel Studio Eval
> > Try the new software tools for yourself. Speed
> compiling, find bugs
> > proactively, and fine-tune applications for parallel
> performance.
> > See why Intel Parallel Studio got high marks during
> beta.
> > http://p.sf.net/sfu/intel-sw-dev
> > _______________________________________________
> > Matplotlib-devel mailing list
> > Matplotlib-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
>
>
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Matplotlib-devel mailing list
Matplotlib-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
