On Wed, Apr 28, 2010 at 11:49 AM, Michael Droettboom <md...@stsci.edu> wrote: > Thanks. Yes, I would consider tabs a bug. A patch is very welcome. > > Mike > > Mark Roddy wrote: >> >> I'm trying to resolve an issue with my source base that uses >> matplotlib. We run our CI tests with the '-tt' option which causes >> errors on mixed tabs/spaces, and this has caused our builds to start >> failing since the inclusion of matploblib on one of our projects due >> to mixed use of tab and space characters in some of the pure python >> code. We're using v0.99.0 and I count 43 occurences of tab characters >> across 5 files in this release. I checked out the trunk and found 26 >> occurrences across 9 files. I determined these via: >> find -name \*.py|xargs grep -P '\t', and >> find -name \*.py|xargs grep -Pl '\t' >> >> According to the style guide[1], use of tabs is a bug, but I wanted to >> inquire if this standard is still in place before filing a bug report. >> I can provide a patch if so (which should only consist of running >> reindent). >> >> Thanks, >> Mark >> >> 1: >> http://matplotlib.sourceforge.net/devel/coding_guide.html#naming-spacing-and-formatting-conventions >> >> >> ------------------------------------------------------------------------------ >> _______________________________________________ >> Matplotlib-devel mailing list >> Matplotlib-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/matplotlib-devel >> > > -- > Michael Droettboom > Science Software Branch > Operations and Engineering Division > Space Telescope Science Institute > Operated by AURA for NASA > >
Thanks Mike. I'll open a bug with the patch attached. -Mark ------------------------------------------------------------------------------ _______________________________________________ Matplotlib-devel mailing list Matplotlib-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
