On Thu, Jul 29, 2010 at 3:39 PM, Eric Firing <efir...@hawaii.edu> wrote:
> On 07/29/2010 09:31 AM, Benjamin Root wrote:
> [...]
> >
> > Good catch, Jeff. Looking over the code, looks like both the input
> > data, x, and the weights get similar pre-processing done to ready it
> > for histogramming. It appears that a fix was made to how x was being
> > processed, but the same was not done to weights. I have a patch
> > that fixes the pre-processing of weights, and also adds comments to
> > both blocks of code to remind future developers to make sure changes
> > are made to both chunks of code.
> >
> > The functional part of the change was to check if the first element
> > of weights was an iterable or not. Before, the weights array as in
> > the given example would be considered 1-element weights for 3
> > datasets, rather than 3-element weights for 1 dataset.
> >
> > Ben Root
> >
> >
> > Re-pinging on my proposed patch. Also, should it go into just the
> > trunk, or should it also go into the branch?
>
> Ben,
>
> Go ahead, trunk and branch, since it is a bugfix.
>
> Thank you.
>
> Eric
>
>
Done in r8595 and r8596.
As a side-note, it looks like various files that have been changed due to
svnmerge.py are still showing themselves as having their properties
modified. Is this ok?
Ben Root
------------------------------------------------------------------------------
The Palm PDK Hot Apps Program offers developers who use the
Plug-In Development Kit to bring their C/C++ apps to Palm for a share
of $1 Million in cash or HP Products. Visit us here for more details:
http://p.sf.net/sfu/dev2dev-palm
_______________________________________________
Matplotlib-devel mailing list
Matplotlib-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
