On 09/16/2010 01:04 PM, Jason Grout wrote:
> On 9/16/10 5:24 PM, Eric Firing wrote:
>> On 09/16/2010 09:50 AM, Jason Grout wrote:
>>> As a follow-up, I've implemented the patch for CXX and also patches for
>>> the other files which do not include Python.h first here:
>>>
>>> http://github.com/jasongrout/matplotlib/commit/a961c299f5d589dae87e06caf54975eb657ebf3b
>>>
>>>
>>> I've also attached the patch.
>>>
>>> This patch gets rid of the warnings about redefining things on OSX
>>> 10.6.4 (see my last message on this thread).
>>>
>>> Thanks,
>>>
>>> Jason
>>
>> Jason,
>>
>> I tested your patch with Ubuntu 10.10, and it failed.  The problem is
>> that something is including setjmp.h before libpng.h tries to do so via
>> pngconf.h, resulting in an error as the compiler trips over the following:
>
>
> What file caused the error (i.e., what file was compiling?)

Sorry, I wasn't thinking straight, or I would have included that.  It 
was _backend_agg.cpp.  However, if I swap the order of inclusion of 
png.h and Python.h in that file, then redefinition warnings are 
generated when it compiles,

In file included from /usr/include/python2.6/Python.h:8,
                  from src/backend_agg.cpp:6:
/usr/include/python2.6/pyconfig.h:1031: warning: "_POSIX_C_SOURCE" redefined
//usr/include/features.h:162: note: this is the location of the previous 
definition
/usr/include/python2.6/pyconfig.h:1040: warning: "_XOPEN_SOURCE" redefined
//usr/include/features.h:164: note: this is the location of the previous 
definition

...

the compilation proceeds, and then fails with _png.cpp:

In file included from /usr/include/libpng12/png.h:518,
                  from src/_png.cpp:4:
/usr/include/libpng12/pngconf.h:371: error: expected constructor, 
destructor, or type conversion before ‘.’ token
/usr/include/libpng12/pngconf.h:372: error: ‘__dont__’ does not name a type
error: command 'gcc' failed with exit status 1

Eric



>
> Thanks,
>
> Jason
>
>
> ------------------------------------------------------------------------------
> Start uncovering the many advantages of virtual appliances
> and start using them to simplify application deployment and
> accelerate your shift to cloud computing.
> http://p.sf.net/sfu/novell-sfdev2dev
> _______________________________________________
> Matplotlib-devel mailing list
> Matplotlib-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/matplotlib-devel



------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________
Matplotlib-devel mailing list
Matplotlib-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/matplotlib-devel

Reply via email to