On Tue, Sep 6, 2011 at 9:53 AM, Michael Droettboom <md...@stsci.edu> wrote: > It occurred to me that it's also possible to file pull requests very > early on while working on a branch. This would make these branches that > others may care about more visible. We would just want some convention > to say "wait -- this branch isn't done yet, don't merge". >
We do that all the time: we simply say "this PR isn't meant for merge yet, just to get the discussion going while the problem is worked on". In IPython, we've merged over 250 PRs since switching to github, and I think we've had *two* long-lived branches in the main repo (newparallel and htmlnotebook). I still think that's the right approach, as situations like these should be exceptional. I think getting used to many long-lived branches in the main repo precisely encourages the kind of workflow that leads to hard-to-review, hard-to-integrate branches. By *not* putting them in the main repo, there's a certain pressure on keeping things small, self-contained and easy to review in little pull requests. Each time we've done one of these monster branches there's been a solid reason to do it, but it has required summoning extra resources, committing big chunks of time for difficult and lengthy review periods, and being very careful about how they can go out of sync with the rest of the repo. So while occasionally necessary, these things have such a high cost that I absolutely want a workflow that discourages them in everyday practice. HTH, f ------------------------------------------------------------------------------ Special Offer -- Download ArcSight Logger for FREE! Finally, a world-class log management solution at an even better price-free! And you'll get a free "Love Thy Logs" t-shirt when you download Logger. Secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsisghtdev2dev _______________________________________________ Matplotlib-devel mailing list Matplotlib-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
