On Tue, Sep 13, 2011 at 1:11 PM, Eric Firing <efir...@hawaii.edu> wrote:
> On 09/13/2011 02:19 AM, Pim Schellart wrote: > > Dear Eric (and other developers), > > > > I have implemented the requested changes and the resulting diff can be > > seen at > https://github.com/pschella/matplotlib/compare/master...cubehelix > > I tried to do a better job at documentation and hope this is > > sufficient, let me know if something is missing. > > Pim, > > I haven't tried it yet, but the code looks nice! Go ahead and click > your "pull request" button so that it shows up on the main matplotlib > repo list of pull requests. > > > I'm not sure exactly what you meant with your suggestion to define > > named functions inside the main function body but I hope my new > > implementation more closely matches your wishes. > > It does. I did not recognize that only a single function was needed. > > > I have opted for a factory function within the main function to avoid > > the code duplication associated with creating a named function for > > each color component. > > Good! > > Eric > > We shouldn't forget to add mention of this new colormap to the What's New page. Ben Root
------------------------------------------------------------------------------ BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA Learn about the latest advances in developing for the BlackBerry® mobile platform with sessions, labs & more. See new tools and technologies. Register for BlackBerry® DevCon today! http://p.sf.net/sfu/rim-devcon-copy1
_______________________________________________ Matplotlib-devel mailing list Matplotlib-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
