On 2012/10/14 12:17 AM, Damon McDougall wrote: > On Sun, Oct 14, 2012 at 2:23 AM, Eric Firing <efir...@hawaii.edu> wrote: >> That would be my preference; but has Mike written anything about where PEP8 >> changes should go? > > All I can find is this: https://github.com/matplotlib/matplotlib/pull/1153 >
Thanks. It's better than nothing, but hardly crystal-clear as guidance for the present situation. Mike's idea, as a compromise, was to "put some cleanup things (such as this) prior to the RC" but after creation of the branch. It is now well past rc3. It seems to me that putting such massive changes in now means that we should get them all in, then have another RC, and then wait a while. In addition, if this is to be the course of action, I think it would be better to rebase each PR against v1.2.x prior to review and merging so that we can be inspecting exactly the changes that will be made to v1.2.x, instead of cherry-picking. I did ask Mike earlier about cherry-picking backwards versus merging maintenance into master, and he confirmed that the latter remained the normal practice. My first choice would still be to not put any of the PEP8 things in 1.2.x, and absolutely minimize future changes on 1.2.x, freezing it ASAP. Eric ------------------------------------------------------------------------------ Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev _______________________________________________ Matplotlib-devel mailing list Matplotlib-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
