Hi David, Le 19/01/2014 18:31, David Reed a écrit : > I've implemented a new feature called shade_color which will either > brighten or darken a color based on a certain percentage. Compare URL > is here: > > https://github.com/dvreed77/matplotlib/compare/master...shade_color > A nice helper function. Ideally, I feel it would be great to have L a b color support in matplotlib, but that's far beyond this discussion.
Two small remarks: * I feel it unnecessary to rename your colorsys imports: "from colorsys import rgb_to_hls as rgb2hls, hls_to_rgb as hls2rgb" -> only few characters less at the cost of a loss in readability (I mean in case someone want to google "colorsys rgb2hls"...) * instead of a "percent" argument (centered around 100), I feel like a float centered around 1.0 would be nicer. The same way rgb values are expressed in [0,1] best, Pierre
<<attachment: pierre_haessig.vcf>>
------------------------------------------------------------------------------ CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments & Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________ Matplotlib-devel mailing list Matplotlib-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
