John and T J,
L1587 at lines.py
def set_mfc(self, val):
'alias for set_markerfacecolor'
self.set_markerfacecolor(val, alt=alt)
"alt" is not defined and it currently raises an exception.
By the way, I noticed that the current approach is to implement
fillstyle for EVERY markers.
An alternative approach would be using a big enough circle for
fillstyle and clip it with the full marker path.
The number of "draw_markers" call increases but the code will be much
simplified and more easy to maintain. Just a thought.
Regards,
-JJ
On Tue, Feb 16, 2010 at 9:39 PM, John Hunter <jdh2...@gmail.com> wrote:
> On Mon, Feb 15, 2010 at 8:28 PM, T J <tjhn...@gmail.com> wrote:
>> On Mon, Feb 15, 2010 at 5:22 PM, John Hunter <jdh2...@gmail.com> wrote:
>>> Very nice and thorough work. I think this should be included, but
>>> I'll wait to hear from other developers before committing. Could you
>>> confirm that the unit tests pass?
>>>
>>>>>> import matplotlib
>>>>>> matplotlib.test()
>>>
>>
>> Confirmed on rev 8133:
>>
>> Ran 124 tests in 341.585s
>>
>> FAILED (KNOWNFAIL=2, errors=2)
>> and the errors were something to do with hexbin extents and the figimage
>> method.
>>
>
> Great -- I committed this patch in r8138
>
>
>>> I think the markerangle would also be a useful contribution, though it
>>> would render some of the markers redundant (eg triangle left, right,
>>> etc, would all just be triangles with different angles...)
>>>
>>
>> That was a concern I had as well, but I suppose > ^ v < (etc) could
>> just be considered shortcuts to particular angles. Presumably, we
>> would not be removing them. Correct? Also, is the standard to have
>> the angle specified in degrees? So what is more useful: markerangle
>> or markerdeg?
>
> We would definitely be leaving these as shortcuts and for backward
> compatibility. And yes the standard is to use degrees -- for
> consistency with the text "rotation" property, we may want
> markerrotation specified in degrees.
>
>>
>> The other difference is that when one specifies fillstyle='left', then
>> it would only apply to the marker at 0 degrees. Whereas, marker='v',
>> fillstyle='left', markerangle=0 would correspond to marker='^',
>> fillstyle='right', markerangle=180 (or something like that).
>
> You can think about what the right way to do this is. My first
> inclination is that that left, right, etc, apply to the unrotated
> marker, and then you apply the rotation. So 'd' with markerrotation=0
> and fillstyle='left' would be identical to 'd' with fillstyle='right'
> and markerrotation=180. But any convention you want to apply would
> probably be fine as long as it is documented. Note I am not sure this
> is a terribly useful feature, but it might be marginally useful and it
> seems like something that could be implemented unobtrusively. So
> don't kill yourself on it.
>
> Thanks again for the nice work.
>
> JDH
>
> ------------------------------------------------------------------------------
> SOLARIS 10 is the OS for Data Centers - provides features such as DTrace,
> Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
> http://p.sf.net/sfu/solaris-dev2dev
> _______________________________________________
> Matplotlib-users mailing list
> Matplotlib-users@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/matplotlib-users
>
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Matplotlib-users mailing list
Matplotlib-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/matplotlib-users
