2011/11/10 Benjamin Root <ben.r...@ou.edu>:
> On Wednesday, November 9, 2011, Friedrich Romstedt
> <friedrichromst...@gmail.com> wrote:
>> ``git bisect`` finds "some" first bad commit, but due to the commits
>> in other branches after the first real bad commit it gets it a bit
>> wrong.  The binary search then skips too far.
>
> Friedrich, just curious.  Is your Git mpl repo a clean clone from
> github.com/matplotlib and *not* from astraw's experimental repo, right?  I
> haven't had issues with bisect before and so I wonder if somehow you might
> have rebased astraw's repo with mpl's repo, which could have introduced
> issues?

No issues like that, clean clone (although I forked it and then cloned that).

For the bisect, without further reading it'll be speculation.  I
guess, bisecting on the basis of branches is difficult, just imagine
you have merged in some branch.  Since you can specify only one "good"
commit as starting point, if the merge occured later, the whole other
branch would have to be considered for bisecting.  I guess that's not
what bisect does.

The machanism, as I imagine it, to make bisect not work, is like this:
The good commit is on branch A, bad commits are on branch B, and they
are intermangled in the time line.  So bisect might just hit always,
up to some point, the good commits, concluding that everything between
them is good too, what is wrong (because only those from A are good,
the B ones not).

Furthermore, Michael is right, while bisecting I didn't ``rm build/``
properly; I just did ``python2.6 setup.py clean``.  Later on I did
that properly, after I noticed that the offending commit reported by
bisect actually runs cleanly.  I then wrote a test script for ``git
bisect run`` that applies all those steps, so I couldn't keep
forgetting it any longer :-)

Friedrich

------------------------------------------------------------------------------
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
_______________________________________________
Matplotlib-users mailing list
Matplotlib-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/matplotlib-users

Reply via email to